Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keyword arguments passed to specific solvers #135

Closed
ArnoStrouwen opened this issue Jan 18, 2023 · 6 comments
Closed

keyword arguments passed to specific solvers #135

ArnoStrouwen opened this issue Jan 18, 2023 · 6 comments

Comments

@ArnoStrouwen
Copy link
Member

Currently, some keywords specific to each cubature method have to be passed as a keyword to solve, while others are present in the struct for the solver algorithm.

I would prefer if all the algorithm specific things become fields in the struct of that algorithm and that we error on anything but a few common keywords, similar to how it works for differential equations.

@ChrisRackauckas
Copy link
Member

Agreed

@agerlach
Copy link
Collaborator

What is the status of this? This looks like it was implemened, at least for CUBA but was never released? e7df9ea

@agerlach
Copy link
Collaborator

It looks like the current release of IntegralsCuba (v0.2.2) still supports passing alg specific keywords as kwargs in solve however, the kwarg check in Integrals solve is preventing its usage. Can this get released?

@ChrisRackauckas
Copy link
Member

I set a release, v0.3.0, let me know if that doesn't work in about half an hour.

@agerlach
Copy link
Collaborator

Thanks

@agerlach
Copy link
Collaborator

It looks like IntegralCubature has the same issue. Can you make a release?

@lxvm lxvm mentioned this issue Mar 3, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants