Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EigenSolve.jl or not [BifurcationKit] #561

Open
rveltz opened this issue Nov 29, 2024 · 2 comments
Open

EigenSolve.jl or not [BifurcationKit] #561

rveltz opened this issue Nov 29, 2024 · 2 comments
Labels
question Further information is requested

Comments

@rveltz
Copy link
Contributor

rveltz commented Nov 29, 2024

Hi,

In BifurcationKit.jl, there is an infrastructure that looks a bit like LinearSolve.jl but for eigensolvers (see here). I am wondering if this would be a good idea to make a new package EigenSolve.jl where a single interface would give access to many possible packages (KrylovKit.jl, ArnoldiMethods.jl, ...). An advantage would be to have Krylov-space re-use but also to have, say Shift-Invert pre-conditioning available for all methods (it is not available for KrylovKit.jl at the moment).

Or should it live in LinearSolve.jl?

Best regards

@rveltz rveltz added the question Further information is requested label Nov 29, 2024
@ChrisRackauckas
Copy link
Member

I am on the fence whether it should be LinearSolve.jl or EigenSolve.jl. The reason is because there's a good amount of infrastructure I think that can be reused here regarding init and solve! handling, but you wouldn't want to make ARPACK be a hard dependency for the default algorithm.

Note this is already being discussed in #143. But basically, yes SciML needs to support something here, it has many requests, and we just haven't gotten to it yet.

@j-fu
Copy link
Contributor

j-fu commented Dec 1, 2024

... I would at least have an eye on such an effort (need to be careful with commitments due to finite bandwith...).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants