Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

autodiff = Val{true}() vs autodiff = true in solver definitions #2391

Open
ArnoStrouwen opened this issue Aug 18, 2024 · 1 comment
Open

autodiff = Val{true}() vs autodiff = true in solver definitions #2391

ArnoStrouwen opened this issue Aug 18, 2024 · 1 comment
Labels
bug

Comments

@ArnoStrouwen
Copy link
Member

Some solvers use Val, others not:
https://github.com/SciML/OrdinaryDiffEq.jl/blob/master/lib/OrdinaryDiffEqRosenbrock/src/algorithms.jl#L114
https://github.com/SciML/OrdinaryDiffEq.jl/blob/master/lib/OrdinaryDiffEqRosenbrock/src/algorithms.jl#L155

Is this intentional, or should we standardize to one of the two?
@ChrisRackauckas
Copy link
Member

We should standardize on Val.

But I wouldn't worry about it. We're changing this autodiff argument to use ADTypes.jl hopefully in the next month. That's a bigger breaking change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ChrisRackauckas @ArnoStrouwen