Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: cleanup deps and replace SparseDiffTools with SciMLJacobianOperators #1124

Merged
merged 11 commits into from
Oct 7, 2024
Merged

refactor: cleanup deps and replace SparseDiffTools with SciMLJacobianOperators #1124

merged 11 commits into from
Oct 7, 2024

Conversation

avik-pal
Copy link
Member

No description provided.

@avik-pal
Copy link
Member Author

I think we should drop the NonlinearSolve dep in DiffEqCallbacks a weakdep as a breaking change

@avik-pal
Copy link
Member Author

avik-pal commented Sep 27, 2024 •
edited
Loading

Tests for steadystateadjoint pass locally. We need to wait for the following:

  • SciMLJacobianOperators to be registered (EOD today)
  • OptimizationBase still does support Enzyme 0.13

This was referenced Sep 27, 2024
Merged
Closed
@avik-pal
Copy link
Member Author

avik-pal commented Oct 1, 2024

We are getting there, we need

add SteadyStateDiffEq#avik-pal-patch-1 ModelingToolkit#master OptimizationBase#main

@avik-pal avik-pal marked this pull request as ready for review October 4, 2024 19:20
@ChrisRackauckas
Copy link
Member

Looks like shadowing is failing?

@avik-pal
Copy link
Member Author

avik-pal commented Oct 6, 2024

yeah, typo in refactor. Should be fixed now. The docs are broken but Vaibhav has a open PR for that so I am not touching it atm.

@ChrisRackauckas ChrisRackauckas merged commit 1710979 into master Oct 7, 2024
16 of 17 checks passed
@ChrisRackauckas
Copy link
Member

Shit didn't mean to click that. There was still an error in shadowing?

@ChrisRackauckas ChrisRackauckas deleted the ap/sdifftools branch October 7, 2024 10:13
@avik-pal
Copy link
Member Author

avik-pal commented Oct 7, 2024

Could that be from any of the packages being unlocked from upgrading? The only change in the shadowing was @unpack to (; . Quite a few of the packages while allowed to update weren't being tested in CI due to compat issues.

@ChrisRackauckas
Copy link
Member

It could be a tolerance thing, since it uses random sampling and maybe something about the randomness changed. Maybe make a PR that bumps the ensemble size?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrisRackauckas ChrisRackauckas Awaiting requested review from ChrisRackauckas

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@avik-pal @ChrisRackauckas