Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Major llama.cpp Change Notes #184

Closed
2 of 4 tasks
martindevans opened this issue Sep 28, 2023 · 4 comments
Closed
2 of 4 tasks

Major llama.cpp Change Notes #184

martindevans opened this issue Sep 28, 2023 · 4 comments

Comments

@martindevans
Copy link
Member

martindevans commented Sep 28, 2023

llama.cpp 3328 just got merged. This contains a major change to the API which will require some big changes to LLamaSharp to support.

  • Make a release before this change, with current API
  • Make basic changes to low level API
  • Adapt current executors to work with new API (minimal changes)
    • I think we're maybe not going to do this, since there's general agreement the executors need completely replacing anyway.
  • Work out how to expose new capabilities (entirely new executor)
@AshD
Copy link

AshD commented Sep 30, 2023

I ran into this issue when I wanted to try the new mistral model.
I updated the llama.cpp dlls and it failed the token generation with current main branch llamasharp branch.

It's tough to keep up with Llama.cpp breaking changes and all the new models coming in daily :-)

@martindevans
Copy link
Member Author

That's odd, I actually tried out Mistral-7B-Instruct earlier today using 0.5.1 and it worked perfectly.

@AshD
Copy link

AshD commented Sep 30, 2023

Thanks Martin. I used the current Llamasharp main branch with the Cuda 11 dll in runtime folder and it worked!

I thought Mistral required the new llama dlls and when I had tried it with yesterday's Llama.cpp dlls, it threw the tokenization error.

Thanks again,
Ash

@martindevans
Copy link
Member Author

martindevans commented Dec 2, 2023

(Batched executor is still in progress)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants