Fuzz more projection boundaries to work with proj >= 5 #1148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You can't just check the bounds, because the projected longitudinal limits produce a wedge, so if they're in the wrong place, the bounds are still the same. Instead, check that the entirety of the boundary is the same as the default.
I do not know the correct values, but these simply codify the results as they currently are.
These all use projections of min/max longitude that suffer from the new proj wraparound behaviour. But they never had tests until now.
dopplershift
approved these changes
Oct 15, 2018
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So I missed a few projections in #1124 that use a projection of min/max longitudes to determine the boundary. They are currently broken with proj5.
This fixes those projections and adds some tests so that they won't break again.