-
Notifications
You must be signed in to change notification settings - Fork 368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moved the nightshade implementation into a feature. #1181
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuLogic
reviewed
Nov 13, 2018
pelson
force-pushed
the
nightshade_feature
branch
from
November 13, 2018 07:19
99530cc
to
2ec87d5
Compare
stickler-ci
reviewed
Nov 13, 2018
QuLogic
reviewed
Nov 13, 2018
👍 to making this a feature. |
…shade, and improved the docstrings for the new functionality.
pelson
force-pushed
the
nightshade_feature
branch
from
November 14, 2018 04:37
f3ab6c7
to
acae5d3
Compare
OK. Ready for final review I think. |
QuLogic
approved these changes
Nov 14, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor fix.
This was referenced Nov 14, 2018
Thanks for the review @QuLogic. Very happy to see this as a feature 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Creates a Nightshade feature that can be added to a cartopy GeoAxes, rather than a
.nightshade
method on the GeoAxes. (follow up to #1135)The reason is one of cleanliness on the GeoAxes API, as well as a better abstraction for future cartopy growth (e.g. alternative backends)
Implications
cartopy/feature.py
moved tocartopy/feature/__init__.py
cartopy/mpl/_solar.py
inlined intocartopy/feature/nightshade.py
(solar physics don't need to belong in a matplotlib interface)