Remove "cfeature.LAND" from "Feature Creation" example ?

[jypeter]

In the nice example provided on the Feature Creation page, you could probably remove the useless line:
B) ax.add_feature(cfeature.LAND)
because you have already called
A) ax.stock_img()

As a matter of fact, B) being called after A), it should theoretically be plotted above A). I see you are using a default zorder=-1 for LAND, so it is probably below everything else (did not know you could use negative zorder values)

>>> cfeature.LAND.kwargs
{'edgecolor': 'face', 'zorder': -1, 'facecolor': array([0.9375  , 0.9375  , 0.859375])}

If I use ax.add_feature(cfeature.LAND, zorder=10), I do get land with a uniform color above the stock image on land (and the stock ocean elsewhere)

[jypeter]

Hmmm, on the other hand, there is the following comment

    # Put a background image on for nice sea rendering.
    ax.stock_img()

The comment does not mention using the stock image for land! Is the fact that we see the stock image rather than a flat color on land in this example a bug or a feature?

[Jeitan]

Sort-of related (since this is active) ... when an old issue gets a new comment, does it float back to the top of anything? I was going to post an issue relating to the LAND feature, but found an effective duplicate #2030 . It's quite old, but it got no activity and the problem is still occurring (I put a lengthy comment there). To raise visibility is that enough or should I make a new issue and reference the other one? I don't want to make extra noise for folks if it's a duplicate though...

[dopplershift]

@Jeitan It's enough just to comment on the old issue, at least to trigger notifications and to move things to the top in the (non-default) "most recently updated" sort on issues.

[Jeitan]

@dopplershift Great, thanks! Glad I didn't make a new issue then.