Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Encoding in io.shapereader #2041

Closed
smartlixx opened this issue Apr 29, 2022 · 0 comments · Fixed by #2236
Closed

Encoding in io.shapereader #2041

smartlixx opened this issue Apr 29, 2022 · 0 comments · Fixed by #2236
Milestone
0.23

Comments

@smartlixx
Copy link
Contributor

smartlixx commented Apr 29, 2022 •
edited
Loading

Description

io.shapereader currently does not support encoding specification. It relies on pyshp under the hood, but pyshp supported encoding ever since v2.0 (back in the year of 2018). It would be necessary for io.shapereader to support encoding as well.

Its implementation should be straightforward. If OK, I can make a PR.
@smartlixx smartlixx changed the title Encoding in io.ShapeReader Encoding in io.shapereader Apr 29, 2022
@greglucas greglucas added this to the 0.21 milestone Apr 29, 2022
@QuLogic QuLogic modified the milestones: 0.21, 0.22 Sep 11, 2022
@dopplershift dopplershift modified the milestones: 0.22, Next Release Aug 4, 2023
@smartlixx smartlixx mentioned this issue Aug 8, 2023
Closed
@lgolston lgolston linked a pull request Oct 13, 2023 that will close this issue
Add documentation, kwargs for Reader #2236
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.23
Development

Successfully merging a pull request may close this issue.

Add documentation, kwargs for Reader lgolston/cartopy
5 participants
@dopplershift @QuLogic @greglucas @smartlixx @lgolston