-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge Strategy #2766
Comments
I can't help thinking that whether this is right or wrong is in the eye of the user, and depends on how they want to use the data. The above example looks very much like the data I use, and the way Iris has organised it seems sensible enough to me. It's possible that the user needs I have my own function |
First things first, Let's take the above as given, I doubt we would change the behaviour of merge in this instance. It has made a heuristic choice that in many circumstances was a really good one. The logical next step is to provide functionality to the user that makes it fast to swap dimensions around - perhaps even producing higher dimensional cubes that do contain empty data. I'm sure there are a number of good API options for this - xarray may be a good source of inspiration on the matter. In summary: merge is unlikely to change its strategy based on this example, but I believe you are describing useful functionality that sits alongside merge/concatenate. |
In order to maintain a backlog of relevant issues, we automatically label them as stale after 500 days of inactivity. If this issue is still important to you, then please comment on this issue and the stale label will be removed. Otherwise this issue will be automatically closed in 28 days time. |
This stale issue has been automatically closed due to a lack of community activity. If you still care about this issue, then please either:
|
It seems Iris' strategy when merging cubes is to create the maximum number of dimensions it can, even if there is an 'acceptable' cube with fewer dimensions (i.e., a cube with no anonymous dimensions). For example, cubes with scalar coordinates taken from the following sets of points will merge into a 2 x 3 cube, but could also merge into a 1D cube of size 6:
I've recently had a user report a situation where this strategy resulted in a cube which seemed wrong. A PP load operation resulted in a cube with the following signature:
But it seems more sensible for there to be a single
time
dimension, rather than separateforecast_period
andforecast_reference_time
dimensions.The text was updated successfully, but these errors were encountered: