Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance Shift(s): 11da71b7 #5167

Closed
github-actions bot opened this issue Feb 21, 2023 · 1 comment
Closed

Performance Shift(s): 11da71b7 #5167

github-actions bot opened this issue Feb 21, 2023 · 1 comment
Assignees
Labels
Bot A bot generated issue/pull-request Type: Performance

Comments

@github-actions
Copy link
Contributor

Benchmark comparison has identified performance shifts at

Please review the report below and take corrective/congratulatory action as appropriate 🙂

Performance shift report
       before           after         ratio
     [ca42c30b]       [11da71b7]
     <main~1>         <main>    
+         155±5ms          210±4ms     1.35  load.ManyVars.time_many_var_load

Generated by GHA run 4227658143

@github-actions github-actions bot added Bot A bot generated issue/pull-request Type: Performance labels Feb 21, 2023
@trexfeathers
Copy link
Contributor

I'm not especially surprised, and IMO thread safety is bound to come with some costs. This cost seems sufficiently minor to me (feel free to disagree).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bot A bot generated issue/pull-request Type: Performance
Projects
None yet
Development

No branches or pull requests

1 participant