Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gdpr): delete inactive accounts. #1979

Merged
merged 2 commits into from
May 24, 2020
Merged

fix(gdpr): delete inactive accounts. #1979

merged 2 commits into from
May 24, 2020

Conversation

teleyinex
Copy link
Member

This new PR fixes a problem with the deletion of accounts.

First it simplifies the process:

  • We check for users that have sent a taskrun more than X months ago.
  • For those users, we send an email saying that if in the coming month
    they do not contribute again, their accounts will be deleted.
  • We then run another job that will check for users that have been
    notified one month ago or more, if they exist, those accounts are
    deleted.
  • As soon as an account submits a taskrun the notified_at value changes
    to null, disabling the deletion.

@teleyinex
fix(gdpr): delete inactive accounts.
5dce093 
This new PR fixes a problem with the deletion of accounts.

First it simplifies the process:

 * We check for users that have sent a taskrun more than X months ago.
 * For those users, we send an email saying that if in the coming month
 they do not contribute again, their accounts will be deleted.
 * We then run another job that will check for users that have been
 notified one month ago or more, if they exist, those accounts are
 deleted.
 * As soon as an account submits a taskrun the notified_at value changes
 to null, disabling the deletion.
@teleyinex
chore: install email_validator.
cdb2274
@coveralls
Copy link

Coverage Status

Coverage increased (+0.002%) to 97.93% when pulling cdb2274 on delete-old-users into 2736557 on master.

@teleyinex teleyinex merged commit 6d3569c into master May 24, 2020
@teleyinex teleyinex deleted the delete-old-users branch May 24, 2020 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@teleyinex @coveralls