Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

beaver-notes: Add version 3.5.0 #13661

Merged
merged 8 commits into from
Aug 21, 2024
Merged

beaver-notes: Add version 3.5.0 #13661

merged 8 commits into from
Aug 21, 2024

Conversation

o-l-a-v
Copy link
Contributor

@o-l-a-v o-l-a-v commented Jul 19, 2024

Closes #13660

@github-actions GitHub Actions
Copy link
Contributor

All changes look good.

Wait for review from human collaborators.

beaver-notes

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

@aliesbelik
Copy link
Collaborator

aliesbelik commented Jul 20, 2024 •
edited
Loading

  • Please follow the standard order of fields in the json file, as per Contributing Guide.
  • Add hash extraction for autoupdate section (use e.g. gnucash manifest for reference if you need one).

@aliesbelik aliesbelik changed the title Added manifest for Beaver Notes beaver-notes: Add version 3.4.0 Jul 20, 2024
@o-l-a-v
Copy link
Contributor Author

o-l-a-v commented Jul 20, 2024 •
edited
Loading

Sorry for not following the contribution guidelines at first try. Again. 😖

Fixed indent size and JSON ordering. But the second point is blocked by:

@aliesbelik
Copy link
Collaborator

/verify

@github-actions GitHub Actions
Copy link
Contributor

All changes look good.

Wait for review from human collaborators.

beaver-notes

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

@o-l-a-v o-l-a-v mentioned this pull request Aug 1, 2024
Open
@o-l-a-v o-l-a-v changed the title beaver-notes: Add version 3.4.0 beaver-notes: Add version 3.5.0 Aug 3, 2024
@o-l-a-v
Copy link
Contributor Author

o-l-a-v commented Aug 12, 2024 •
edited
Loading

I had an instance were install failed beacuse it could not run the following due to CrowdStrike Falcon Sensor placing handles on content inside $PLUGINSDIR:

Remove-Item -Path "$dir\``$*\", \"$dir\Uninstall*\" -Force -Recurse

Ref: ScoopInstaller/Scoop#6097

So I added a retry on that step to the manifest.

@aliesbelik
Copy link
Collaborator

/verify

@github-actions GitHub Actions
Copy link
Contributor

All changes look good.

Wait for review from human collaborators.

beaver-notes

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

@aliesbelik aliesbelik merged commit 3b68b71 into ScoopInstaller:master Aug 21, 2024
2 checks passed
@o-l-a-v o-l-a-v deleted the add-beaver-notes branch August 21, 2024 21:37
@o-l-a-v o-l-a-v mentioned this pull request Sep 3, 2024
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
review-needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Request]: Beaver Notes
2 participants
@o-l-a-v @aliesbelik