Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update-flow: uninstall after download #1605

Closed
prasannavl opened this issue Jul 18, 2017 · 4 comments
Closed

update-flow: uninstall after download #1605

prasannavl opened this issue Jul 18, 2017 · 4 comments

Comments

@prasannavl
Copy link

Currently, scoop update flow works by uninstall the app, downloading, and then installing again. It would be smoother to recover from network errors, if does the downloading first, and then the uninstall followed by install.

Obviously, not a priority issue, but thought it would be a good design flow to track.

@r15ch13
Copy link
Member

r15ch13 commented Jul 18, 2017

In my opinion, the update and install processes need to be reworked anyway.
When scoop update * fails somewhere down the line (permission errors because the program was running or download errors), it aborts the whole process while leaving you hanging with a broken app and the need to run it again.

The function abort has to be taken down! 🔫

@rrelmy
Copy link
Collaborator

rrelmy commented Jul 18, 2017

I mentioned it in #1372 but never got that far …

@narnaud
Copy link
Contributor

narnaud commented Feb 14, 2019

Any updates on that?
I have the issue from time to time, and it's always a pain to fix.

@rasa
Copy link
Member

rasa commented Feb 15, 2019

@narnaud Yes, I think there is general agreement that this is a flaw, that needs to be addressed. Please consider submitting a PR. My guess is the issue is pretty systemic, or we would have fixed it by now, as it's affected us all at one time or another.

r15ch13 pushed a commit that referenced this issue Mar 7, 2019
This is temporary solution for #2220 until whole install.ps1 refactor is done to make this tweak easily, in the best way one-liner.

- One step closer to #3149
- Closes #2220
- Closes #2343
- Closes #1605
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants