Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve scoop Select-CurrentVersion error by locking to 0.4.2 #5093

Merged
merged 1 commit into from
Oct 11, 2024
Merged

Resolve scoop Select-CurrentVersion error by locking to 0.4.2 #5093

merged 1 commit into from
Oct 11, 2024

Conversation

peterzhuamazon
Copy link
Member

Description

Resolve scoop Select-CurrentVersion error by locking to 0.4.2

Issues Resolved

Temp resolve: ScoopInstaller/Scoop#6180

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@peterzhuamazon
Resolve scoop Select-CurrentVersion error by locking to 0.4.2
6735b6c 
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
@peterzhuamazon peterzhuamazon added bug Something isn't working docker windows labels Oct 11, 2024
@peterzhuamazon peterzhuamazon self-assigned this Oct 11, 2024
@prudhvigodithi
Copy link
Member

Approving to unblock the development, but I would suggest to please add that script directly to the build repo until the scoop issue is resolved.

@peterzhuamazon
Copy link
Member Author

Approving to unblock the development, but I would suggest to please add that script directly to the build repo until the scoop issue is resolved.

Moved to config, but feels like it is extra steps to maintain it until upstream fix.

@peterzhuamazon
Copy link
Member Author

Another question is whether we can move a unlicense file with Apache2.0 license header and added to our repo.

Having a fork and refer here might be the better setup here.

Thanks.

@peterzhuamazon
Copy link
Member Author

peterzhuamazon commented Oct 11, 2024 •
edited
Loading

After offline discussion with @prudhvigodithi on this, in order to avoid licensing issues and since it is such a small change, we would go ahead and use the link from my fork, as it is public and directly fork from scoopinstaller/install since the upstream did not lock version on their install script.

Thanks.

@peterzhuamazon peterzhuamazon force-pushed the fix-scoop-Select-CurrentVersion-not-found branch from 2f1aff7 to 6735b6c Compare October 11, 2024 00:37
@peterzhuamazon peterzhuamazon merged commit f7ee643 into opensearch-project:main Oct 11, 2024
19 checks passed
@peterzhuamazon peterzhuamazon deleted the fix-scoop-Select-CurrentVersion-not-found branch October 11, 2024 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prudhvigodithi prudhvigodithi prudhvigodithi approved these changes

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@gaiksaya gaiksaya Awaiting requested review from gaiksaya gaiksaya is a code owner

@rishabh6788 rishabh6788 Awaiting requested review from rishabh6788 rishabh6788 is a code owner

@zelinh zelinh Awaiting requested review from zelinh zelinh is a code owner

@Divyaasm Divyaasm Awaiting requested review from Divyaasm Divyaasm is a code owner

@tianleh tianleh Awaiting requested review from tianleh tianleh is a code owner

Assignees

@peterzhuamazon peterzhuamazon

Labels
bug Something isn't working distinguished-contributor docker windows
Projects
Engineering Effectiveness Board
Status: ✅ Done
OpenSearch Engineering Effectiveness
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Scoop Select-CurrentVersion error on ltsc2019 Windows Images
2 participants
@peterzhuamazon @prudhvigodithi