Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PreheatIntent and CoolingIntent doesn't check return status #9

Open
filcole opened this issue Dec 19, 2016 · 1 comment
Open

PreheatIntent and CoolingIntent doesn't check return status #9

filcole opened this issue Dec 19, 2016 · 1 comment

Comments

@filcole
Copy link
Contributor

filcole commented Dec 19, 2016

The remote turn on of climate control may fail if the battery is too low. This should be checked for and the user informed if the battery is too low. I think for an example of the response see here: https://github.com/joshperry/carwings/blob/master/protocol.markdown#hvac-remote-activate-result

@ScottHelme
Copy link
Owner

Yeah, the current request is 'fire and forget' by design. Checking for the result generally takes a fair amount of time, during which Alexa would just be sat there and could possibly time out. I think a better approach would be a new intent to check if the AC is on or not, so that can be done separately if the user wants to check it succeeded or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants