Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dry-struct dependency #20

Closed
ngoral opened this issue Apr 26, 2023 · 2 comments
Closed

Update dry-struct dependency #20

ngoral opened this issue Apr 26, 2023 · 2 comments

Comments

@ngoral
Copy link
Contributor

ngoral commented Apr 26, 2023

The whole chain of dependencies is narrowed to using dry-logic, ~> 1.3.0, which unfortunately crashes irb if autocomplete is turned on.
This is fixed in dry-logic of 1.5.0, but it depends on dry-core, >=1.0. The current version of dry-struct has dry-core, ~> 0.9 requirement, which prevents dry-logic from the update.

An update to dry-struct, ~> 0.1.6 would solve the problem. Do you see any problems with that? Both changelogs for dry-struct and dry-core do not show any criminal.
@ScotterC
Copy link
Owner

I've been trying to figure out that crash as well! Thanks for narrowing it down! I'll get that updated asap.

@ScotterC ScotterC mentioned this issue Apr 28, 2023
Merged
@ScotterC
Copy link
Owner

gem 0.1.71 pushed. Sorry I didn't get to this issue for a few days. I'm super grateful you tracked down that crash. It was infuriating :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ScotterC @ngoral