Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to detect if switch failed to change state #134

Open
edgimar opened this issue Feb 26, 2023 · 5 comments
Open

Need to detect if switch failed to change state #134

edgimar opened this issue Feb 26, 2023 · 5 comments

Comments

@edgimar
Copy link

edgimar commented Feb 26, 2023

Describe the bug
It appears that if a switch doesn't provide feedback about it's current state (e.g. maybe it's a template defined switch), and if the switch for some reason doesn't end up in the desired state, smart thermostat isn't able to detect this and try to correct it (e.g by toggling the switch state).

I've attached a screenshot that illustrates this scenario having occurred.

Screenshots
Screenshot_20230226-084813_1

@Andrzej21372137
Copy link

I have exactly the same issues and i thought that i messed something up.

@ScratMan
Copy link
Owner

Is your configuration using the keep_alive parameter ? His role is to regularly check the state of the switch is aligned with the thermostat.

@Andrzej21372137
Copy link

Yes i have it set to 60 sec.

@zarebski-m
Copy link

Is your configuration using the keep_alive parameter ? His role is to regularly check the state of the switch is aligned with the thermostat.

Hi, I know it's unrelated to this issue, but this is the first time I've seen the keep_alive parameter being succinctly explained. The README says that:

keep_alive (Required): sets update interval for the PWM pulse width. If interval is too big, the PWM granularity will be reduced, leading to lower accuracy of temperature control, can be float in seconds, or time hh:mm:ss.

@edgimar
Copy link
Author

edgimar commented Mar 4, 2023

I also have the keep_alive parameter set to 60 seconds, but I believe this issue is not addressed by that parameter (as it currently behaves). Based on the description, it influences the frequency that the PWM output value is updated, but I wonder what happens if the computed output does not differ from the previous output. In this case, is a command issued to the switch telling it to be in a particular state? If not, then this could explain the screenshot I included (assuming that there was one time that a "turn on" command wasn't correctly received/processed by the switch, and the PWM state after that time was only ever "on").

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants