Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Responsiveness is slow #75

Open
csmit86 opened this issue Feb 20, 2022 · 4 comments
Open

Responsiveness is slow #75

csmit86 opened this issue Feb 20, 2022 · 4 comments

Comments

@csmit86
Copy link

csmit86 commented Feb 20, 2022

When I change the preferred temp it always takes a while to turn off or on.
I noticed it's exactly 5 min, which is what I have set in the sampling period parameter.
Is this a bug or expected behavior?

I remember it use to respond directly to user input.

@ScratMan
Copy link
Owner

If you set the sampling period, the PID will reject new commands until the period is ended to accept a new sample. So yes, normal behaviour.
I'll try to add a bypass of this period when target temp is changed.

@dorinvlas
Copy link

If you set the sampling period, the PID will reject new commands until the period is ended to accept a new sample. So yes, normal behaviour. I'll try to add a bypass of this period when target temp is changed.

Hi Adrien. Did you had the opportunity to implement that bypass? If yes in what version?

Thanks for making us more energy efficient ;)

@T81
Copy link

T81 commented Dec 6, 2022

If you set the sampling period, the PID will reject new commands until the period is ended to accept a new sample. So yes, normal behaviour. I'll try to add a bypass of this period when target temp is changed.

This would be great and it is needed. Also adding a small delay of 2-4 seconds before calculating again would be nice, since user's input needs debouncing. ;)

@T81
Copy link

T81 commented Dec 27, 2022

If you set the sampling period, the PID will reject new commands until the period is ended to accept a new sample. So yes, normal behaviour.
I'll try to add a bypass of this period when target temp is changed.

I had the same issue but it wasn't the sampling period but the keep alive setting. Setting it to 1 second fixed this (and a lot of other issues) and I would recommend this setting, even being the default. What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants