Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

api: create v2 endpoints in favor of the v1 endpoints currently used by Anthias from the Settings and home page #2142

Merged
merged 7 commits into from
Nov 26, 2024
Merged

api: create v2 endpoints in favor of the v1 endpoints currently used by Anthias from the Settings and home page #2142

merged 7 commits into from
Nov 26, 2024

Conversation

nicomiguelino
Copy link
Contributor

@nicomiguelino nicomiguelino commented Nov 25, 2024 •
edited
Loading

Changes

  • Created the following endpoints:
    • /api/v2/backup
    • /api/v2/recover
    • /api/v2/reboot
    • /api/v2/shutdown
    • /api/v1/file_asset
    • /api/v1/assets/content
    • /api/v1/assets/order
    • /api/v1/assets/control
  • Updated settings.coffee so that the settings page will use v2 endpoints instead

Screenshots

image
image

@nicomiguelino nicomiguelino changed the title api: create a v2 endpoints in favor of the v1 endpoints currently used by Anthias api: create a v2 endpoints in favor of the v1 endpoints currently used by Anthias from the Settings page Nov 25, 2024
@nicomiguelino nicomiguelino marked this pull request as ready for review November 25, 2024 21:12
@nicomiguelino nicomiguelino requested a review from a team as a code owner November 25, 2024 21:12
@nicomiguelino nicomiguelino changed the title api: create a v2 endpoints in favor of the v1 endpoints currently used by Anthias from the Settings page api: create a v2 endpoints in favor of the v1 endpoints currently used by Anthias from the Settings and home page Nov 25, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 25, 2024

Quality Gate Passed Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@nicomiguelino nicomiguelino changed the title api: create a v2 endpoints in favor of the v1 endpoints currently used by Anthias from the Settings and home page api: create v2 endpoints in favor of the v1 endpoints currently used by Anthias from the Settings and home page Nov 25, 2024
@nicomiguelino nicomiguelino merged commit 1897046 into Screenly:master Nov 26, 2024
6 checks passed
@nicomiguelino nicomiguelino deleted the create-v2-endpoints branch November 26, 2024 15:36
@nicomiguelino nicomiguelino mentioned this pull request Dec 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vpetersson vpetersson vpetersson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Anthias
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nicomiguelino @vpetersson