Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SyncWaterfallHook is not a constructor #149

Open
katiawheeler opened this issue Feb 25, 2020 · 3 comments · Fixed by #150
Open

SyncWaterfallHook is not a constructor #149

katiawheeler opened this issue Feb 25, 2020 · 3 comments · Fixed by #150
Labels

Comments

@katiawheeler
Copy link

katiawheeler commented Feb 25, 2020

Attempting to use this plugin. When I add the plugin to the webpack plugins, I get the following error when running webpack-dev-server:

TypeError: SyncWaterfallHook is not a constructor at URLImportPlugin.apply ...\node_modules\webpack-external-import\webpack\index.js:373:58

Any suggestions as to where to look?

@katiawheeler
Copy link
Author

Looks like manually installing tapable solved this issue. Perhaps missing a peer dependency in 2.2.1?

@maraisr
Copy link
Collaborator

maraisr commented Feb 25, 2020

peerDependencies dont get installed, but rather warns in both npm and yarn afaik. Thinking this should be marked as a dependency.

It is strange that this issue occurred though. Webpack itself marks tapable as a dependency, and as this is a webpack plugin, this package should have resolved... Must be something else at play.

But none the less, we should resolve this.

@ScriptedAlchemy
Copy link
Owner

🎉 This issue has been resolved in version 2.2.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants