Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve performance in BeforeMessageSend() #37

Closed
adnanrahat opened this issue Apr 17, 2018 · 1 comment
Closed

Improve performance in BeforeMessageSend() #37

adnanrahat opened this issue Apr 17, 2018 · 1 comment
Milestone

Comments

@adnanrahat
Copy link

adnanrahat commented Apr 17, 2018

In AzureStorageAttachment::BeforeMessageSend(), the code looks like as

await InitializeClient().ConfigureAwait(false);
if (!configuration.MessageMaxSizeReachedCriteria(message))
{
  return message;
}

I think bringing down the InitializeClient() after the MaxMessage check should improve the performance of the SendMessage call(). Other way to say, for smaller message, we won't initialize the blob clients anymore. Thoughts?

@SeanFeldman SeanFeldman added this to the 2.2.1 milestone Apr 17, 2018
@SeanFeldman
Copy link
Owner

Done. Thank you @adnanrahat.
This is what's done in AfterMessageReceive and should have been done in BeforeMessageSend as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants