Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

external-solr-impl compatible with Solr version 6.6.x #97

Closed
daredevil82 opened this issue Jul 19, 2019 · 4 comments
Closed

external-solr-impl compatible with Solr version 6.6.x #97

daredevil82 opened this issue Jul 19, 2019 · 4 comments
Assignees
Milestone

Comments

@daredevil82
Copy link

I would like to integrate RRE with our existing infrastructure for relevancy analysis. For purposes of flexibility in configuration and deployment, we would like to leverage rre-search-platform-external-solr-impl with our CI infrastructure. However, after talking with @agazzarini on the Relevance Search slack, the current implementation is compatible only with 7.5.x.

We are planning to be on 7.x by EOY, but for now that update is not possible. Having compatibility with 6.x would be a major help.

@mattflax
Copy link
Contributor

I took a look into this - the HTTP client initialisation process is quite different for Solr 6 from that for Solr 7. I also had to change the Jackson versions - Solr 6 uses Jackson 2.5.x, while Solr 7 is on Jackson 2.9.x.

There's a branch on my fork of the main repo, if you're happy to build your own: https://github.com/mattflax/rated-ranking-evaluator/tree/external_solr_6.6

(I've given it a quick test against Solr 6.6.6 locally using the test data set, but haven't tested it extensively.)

@agazzarini I'm not sure the best approach to getting this released to the Maven repo, so no PR yet. Do you have any thoughts how to go about this?

@agazzarini
Copy link
Member

Hi @mattoscln I'm working on the #95 following your approach with a slight change which should fix also this problem. Basically, after some investigation, I think we could use a fixed version (or LATEST) for Solrj, because at the end it is just sending a HTTP request.

I tried using Solrj 8 againsts Solr 8 to 4 and it works, so maybe that could be a right approach to improve the maintainability of that maven repo

@mattflax
Copy link
Contributor

Yes, that sounds like a sensible approach for Solr - it's nice when things are backwards compatible!

@agazzarini agazzarini self-assigned this Aug 1, 2019
@agazzarini
Copy link
Member

Hi @daredevil82 we re-uploaded the RRE maven artifacts, please find here [1] the supported ES & Solr versions.

Let me know
Andrea


[1] https://github.com/SeaseLtd/rated-ranking-evaluator/wiki/Supported%20Versions

@agazzarini agazzarini added this to the 1.1 milestone Apr 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants