#109: Make maximum and default grades configurable. #111
Conversation
- Make fairgrade configurable at construction time; - Use floating point grade values in gain(); - Add default grade values to Metric.
- Make maxgrade and fairgrade configurable at construction time; - Use floating point grade values in gain function.
… point values for grading.
…de to be set via Maven pom.xml: - Add singleton factory for instantiating MetricClassManager instances; - Allow access to default grade values via factory class. - Modify Maven plugins to use factory.
…RR, NDCG, RR to add consistency with pom.xml parameters.
| // Private constructor | ||
| } | ||
|
|
||
| public static MetricClassConfigurationManager getInstance() { |
There was a problem hiding this comment.
The constructor is empty so we could do
private final static MetricClassConfigurationManager INSTANCE = new MetricClassConfigurationManager();
what do you think?
There was a problem hiding this comment.
Sure, I've just made that change. My thinking was to not create before it is required, but it is used at the very beginning, and is not a big class either, so it's a sensible change to make.
|
Great stuff @mattflax (or @mattoscln ?), I put just one trivial comment. |
|
Thanks @agazzarini - I've responded above. (It's @mattflax btw - any commits from the other account were by accident!) |
|
Hi @agazzarini hope things are going well! I'm writing up details for deploying RRE, and wanted to include the changes created by this PR in the documentation. Wanted to see if there was anything I or @mattflax can do to help get this reviewed and merged? I know everything is crazy! Very happy to update the Wiki once this is merged for you ;-) |
|
Hi @epugh many thanks, everything is doing fine here, even we are living in a surreal context. Hope the same there. Thanks again for everything |
This PR makes the following changes, as per this comment on the issue: #109 (comment)
Please let me know of any feedback on these changes!