Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Maven plugin to connect to any search API #112

Merged
merged 5 commits into from
Mar 31, 2020

Conversation

mattflax
Copy link
Contributor

This PR adds a Maven plugin allowing any implementation of SearchPlatform to be used to call an external search API. I've also included an archetype, although it requires more changes than the Solr and ES archetypes to get working - there's a couple of README files with details of how to implement the connectors.

@anthonygroves
Copy link

@mattflax A big +1 from me on this idea of connecting to a search API!
Question - how does this method handle versioning? I see in the settings.json for each version you can define the search API url. Does versioning/comparison require that you are able to query multiple variations of your search API at the same time?

@mattflax
Copy link
Contributor Author

mattflax commented Mar 27, 2020

@anthonygroves You have two options here:

  1. have different versions of your API available and query them via different URLs;
  2. there is a boolean option in the Persistence Configuration, useTimestampAsVersion, which uses the epoch milliseconds value at the start of the evaluation as the version. It does restrict you to a single configuration set, though. It is most likely to be useful when outputting results to an external store, such as Elasticsearch, but it applies with any persistence handler. (It was also undocumented, unfortunately - I've added a note about it to the persistence wiki page.)

@agazzarini
Copy link
Member

Hi @mattflax, great stuff, as usual.

@agazzarini agazzarini merged commit 840e3df into SeaseLtd:master Mar 31, 2020
@mattflax
Copy link
Contributor Author

Thanks @agazzarini - hope you're doing okay in these interesting times!

@mattflax mattflax deleted the generic_evaluation_plugin branch March 31, 2020 11:05
@agazzarini
Copy link
Member

You're welcome @mattflax. Yes, everything is ok, and I agree with you...interesting times! Hope the same there!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants