From 2c0f41472441890b96daba638c9bf73d573bb8c9 Mon Sep 17 00:00:00 2001 From: Dale Henrichs Date: Fri, 15 Mar 2019 11:08:32 -0700 Subject: [PATCH 1/4] Issue #1115: add #SentButNotImplementedTest and #UndefinedSymbolsTest test cases --- .smalltalk.ston | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/.smalltalk.ston b/.smalltalk.ston index 0f42b24c3..d290f699f 100644 --- a/.smalltalk.ston +++ b/.smalltalk.ston @@ -28,6 +28,8 @@ SmalltalkCISpec { #testing : { #exclude : { #packages : [ 'Cryptography.*' ] - } - } + }, + #include : { + #classes : [ #SentButNotImplementedTest, #UndefinedSymbolsTest ] + } } From 1f7c36b617ecee867fca0d97cb32c1663b4dc050 Mon Sep 17 00:00:00 2001 From: Dale Henrichs Date: Fri, 15 Mar 2019 11:23:40 -0700 Subject: [PATCH 2/4] Issue #1115: typo in .smalltalk.ston --- .smalltalk.ston | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.smalltalk.ston b/.smalltalk.ston index d290f699f..ea24bb43f 100644 --- a/.smalltalk.ston +++ b/.smalltalk.ston @@ -30,6 +30,6 @@ SmalltalkCISpec { #packages : [ 'Cryptography.*' ] }, #include : { - #classes : [ #SentButNotImplementedTest, #UndefinedSymbolsTest ] + #classes : [ #SentButNotImplementedTest , #UndefinedSymbolsTest ] } } From a30f4ba7e7e76a217d296e30f8c759a4d6b0f27c Mon Sep 17 00:00:00 2001 From: Dale Henrichs Date: Fri, 15 Mar 2019 11:47:37 -0700 Subject: [PATCH 3/4] Issue #1115: missing }, not missing , .. I think --- .smalltalk.ston | 1 + 1 file changed, 1 insertion(+) diff --git a/.smalltalk.ston b/.smalltalk.ston index ea24bb43f..b015b6692 100644 --- a/.smalltalk.ston +++ b/.smalltalk.ston @@ -32,4 +32,5 @@ SmalltalkCISpec { #include : { #classes : [ #SentButNotImplementedTest , #UndefinedSymbolsTest ] } + } } From 99503f8b1f6b0c1c01b465df9396586b79ebdcf1 Mon Sep 17 00:00:00 2001 From: Dale Henrichs Date: Fri, 15 Mar 2019 12:35:49 -0700 Subject: [PATCH 4/4] Issue #1115: proposed fix --- .../instance/addCookieRFC2965.toStream..st | 7 ++----- .../instance/addCookieRFC6265.toStream..st | 7 +++++++ repository/Seaside-Core.package/WACookie.class/README.md | 4 ++-- 3 files changed, 11 insertions(+), 7 deletions(-) create mode 100644 repository/Seaside-Adaptors-FastCGI.package/WAFastCGIAdaptor.class/instance/addCookieRFC6265.toStream..st diff --git a/repository/Seaside-Adaptors-FastCGI.package/WAFastCGIAdaptor.class/instance/addCookieRFC2965.toStream..st b/repository/Seaside-Adaptors-FastCGI.package/WAFastCGIAdaptor.class/instance/addCookieRFC2965.toStream..st index b8a1eba31..72f510ccd 100644 --- a/repository/Seaside-Adaptors-FastCGI.package/WAFastCGIAdaptor.class/instance/addCookieRFC2965.toStream..st +++ b/repository/Seaside-Adaptors-FastCGI.package/WAFastCGIAdaptor.class/instance/addCookieRFC2965.toStream..st @@ -1,8 +1,5 @@ private addCookieRFC2965: aWACookie toStream: aStream + "https://github.com/SeasideSt/Seaside/issues/1115" - aStream - nextPutAll: 'Set-Cookie: '; - nextPutAll: aWACookie rfc2965String; - nextPut: Character cr; - nextPut: Character lf. \ No newline at end of file + self addCookieRFC6265: aWACookie toStream: aStream diff --git a/repository/Seaside-Adaptors-FastCGI.package/WAFastCGIAdaptor.class/instance/addCookieRFC6265.toStream..st b/repository/Seaside-Adaptors-FastCGI.package/WAFastCGIAdaptor.class/instance/addCookieRFC6265.toStream..st new file mode 100644 index 000000000..32d91377a --- /dev/null +++ b/repository/Seaside-Adaptors-FastCGI.package/WAFastCGIAdaptor.class/instance/addCookieRFC6265.toStream..st @@ -0,0 +1,7 @@ +private +addCookieRFC6265: aWACookie toStream: aStream + aStream + nextPutAll: 'Set-Cookie: '; + nextPutAll: aWACookie rfc6265String; + nextPut: Character cr; + nextPut: Character lf \ No newline at end of file diff --git a/repository/Seaside-Core.package/WACookie.class/README.md b/repository/Seaside-Core.package/WACookie.class/README.md index b98f2503a..5a8913c3f 100644 --- a/repository/Seaside-Core.package/WACookie.class/README.md +++ b/repository/Seaside-Core.package/WACookie.class/README.md @@ -12,10 +12,10 @@ Cookie spec http://tools.ietf.org/html/rfc2109 Cookie 2 spec -http://tools.ietf.org/html/rfc2965 +https://tools.ietf.org/html/rfc6265 HttpOnly http://msdn2.microsoft.com/en-us/library/ms533046.aspx https://bugzilla.mozilla.org/show_bug.cgi?id=178993 -Compared to WARequestCookie I represent the information that is sent to the user agent. \ No newline at end of file +Compared to WARequestCookie I represent the information that is sent to the user agent.