Fixed Err Management around UpdateRepos #607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RefreshAiSummaries now returns any repo errors it gets. They get logged, but won't impact the Sync. When cloning a repo fails, return the error instead of only logging it. Not returning the error risks deleting "unreferenced" rules from that repo. Sync tests no longer have `showAiSummaries` set to true. The `lastSuccessfulAiUpdate` variable wasn't being reset between tests and was wrecking havoc.
jertel
approved these changes
Aug 8, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RefreshAiSummaries now returns any repo errors it gets. They get logged, but won't impact the Sync.
When cloning a repo fails, return the error instead of only logging it. Not returning the error risks deleting "unreferenced" rules from that repo.
Sync tests no longer have
showAiSummariesset to true. ThelastSuccessfulAiUpdatevariable wasn't being reset between tests and was wrecking havoc.