[gui] hardcoded 0.5 pick weight threshold for certain operations should be made configurable

[luca-s]

Dear developers,

I was not able to compute magnitude in scolv for certain events and after some investigation I found out that there is a 0.5 pick weight threshold below which the picks are silently ignored. I have now fixed the issue on my side, so I do not need support.

I just wanted to suggest to make the threshold configurable and also to log the discarded picks so that careful users have a chance to find out what the GUIs are doing.

common/libs/seiscomp/gui/core/locator.cpp

Line 77 in 027cbc8

if ( arrival->weight() < 0.5 ) continue;

common/libs/seiscomp/gui/datamodel/originlocatorview.cpp

Line 5899 in 027cbc8

ar->weight() < 0.5 )

common/libs/seiscomp/gui/datamodel/pickerview.cpp

Line 4545 in 027cbc8

if ( arrival->weight() <= 0.5 ) {

common/libs/seiscomp/gui/datamodel/magnitudeview.cpp

Line 2461 in 027cbc8

if ( Util::getShortPhaseName(ar->phase().code()) != 'P' || weight < 0.5 )

common/libs/seiscomp/gui/datamodel/calculateamplitudes.cpp

Line 290 in 027cbc8

if ( Util::getShortPhaseName(ar->phase().code()) != 'P' || weight < 0.5 ) {

thanks
Luca