Fix setup.py licence classifier #611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In fact, it appears on PyPi as: So the full 2.0 is indicated. The classifier just adds the tag at the bottom which can be used as a search filter on PyPI... |
Codecov Report
@@ Coverage Diff @@
## master #611 +/- ##
==========================================
+ Coverage 81.98% 82.06% +0.07%
==========================================
Files 77 77
Lines 10520 10520
==========================================
+ Hits 8625 8633 +8
+ Misses 1895 1887 -8
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the licence classifier in setup.py, to match Alibi Detect.
"License :: OSI Approved :: Apache 2.0 License"is not a valid classifier, and should be"License :: OSI Approved :: Apache Software License".@jklaise @mauicv just to flag, we're having to specify the less specific "Apache Software Licence" since there are no version specific classifiers. This appears to be a long-running issue (pypi/legacy#91, pypa/trove-classifiers#17). I doubt this is a problem as take the view what's in
LICENCEis our formal licence, and the classifier is a lossy mechanism to indicate the broad family of licence. But flagging here just in case...