Skip to content

Commit

Permalink
Updated cert-manager API version (#3888)
Browse files Browse the repository at this point in the history
  • Loading branch information
jonathansp committed Jan 29, 2022
1 parent c2941f9 commit 396586b
Show file tree
Hide file tree
Showing 7 changed files with 13 additions and 14 deletions.
6 changes: 3 additions & 3 deletions examples/security/ssl_requests/README.ipynb
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@
"helm install \\\n",
" cert-manager jetstack/cert-manager \\\n",
" --namespace cert-manager \\\n",
" --version v0.16.1 \\\n",
" --version v1.6.1 \\\n",
" --set installCRDs=true"
]
},
Expand All @@ -96,7 +96,7 @@
"source": [
"%%bash\n",
"kubectl apply -f - << END\n",
"apiVersion: cert-manager.io/v1alpha2\n",
"apiVersion: cert-manager.io/v1\n",
"kind: Issuer\n",
"metadata:\n",
" name: selfsigned-issuer\n",
Expand Down Expand Up @@ -147,7 +147,7 @@
"source": [
"%%bash \n",
"kubectl apply -f - << END\n",
"apiVersion: cert-manager.io/v1alpha3\n",
"apiVersion: cert-manager.io/v1\n",
"kind: Certificate\n",
"metadata:\n",
" name: sklearn-default-cert\n",
Expand Down
7 changes: 3 additions & 4 deletions examples/security/ssl_requests/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ kubectl create ns cert-manager
helm install \
cert-manager jetstack/cert-manager \
--namespace cert-manager \
--version v0.16.1 \
--version v1.6.1 \
--set installCRDs=true
```

Expand Down Expand Up @@ -53,14 +53,13 @@ helm install \

Error from server (AlreadyExists): namespaces "cert-manager" already exists


#### Creating issuer so we can deploy certificates


```bash
%%bash
kubectl apply -f - << END
apiVersion: cert-manager.io/v1alpha2
apiVersion: cert-manager.io/v1
kind: Issuer
metadata:
name: selfsigned-issuer
Expand Down Expand Up @@ -88,7 +87,7 @@ END
```bash
%%bash
kubectl apply -f - << END
apiVersion: cert-manager.io/v1alpha3
apiVersion: cert-manager.io/v1
kind: Certificate
metadata:
name: sklearn-default-cert
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{{- if .Values.certManager.enabled -}}
apiVersion: cert-manager.io/v1alpha2
apiVersion: cert-manager.io/v1
kind: Certificate
metadata:
labels:
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{{- if .Values.certManager.enabled -}}
apiVersion: cert-manager.io/v1alpha2
apiVersion: cert-manager.io/v1
kind: Issuer
metadata:
labels:
Expand Down
2 changes: 1 addition & 1 deletion operator/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ run: generate fmt vet manifests_all
install-cert-manager:
kubectl create namespace cert-manager || echo "Namespace cert-manager-exists"
kubectl label namespace cert-manager cert-manager.io/disable-validation=true || echo "namespace cert-manager-already labelled"
kubectl apply --validate=false -f https://github.com/jetstack/cert-manager/releases/download/v0.12.0/cert-manager.yaml
kubectl apply --validate=false -f https://github.com/jetstack/cert-manager/releases/download/v1.6.1/cert-manager.yaml
kubectl rollout status deployment.apps/cert-manager -n cert-manager
kubectl rollout status deployment.apps/cert-manager-cainjector -n cert-manager
kubectl rollout status deployment.apps/cert-manager-webhook -n cert-manager
Expand Down
4 changes: 2 additions & 2 deletions operator/config/certmanager/certificate.yaml
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
# The following manifests contain a self-signed issuer CR and a certificate CR.
# More document can be found at https://docs.cert-manager.io
apiVersion: cert-manager.io/v1alpha2
apiVersion: cert-manager.io/v1
kind: Issuer
metadata:
name: selfsigned-issuer
namespace: system
spec:
selfSigned: {}
---
apiVersion: cert-manager.io/v1alpha2
apiVersion: cert-manager.io/v1
kind: Certificate
metadata:
name: serving-cert # this name should match the one appeared in kustomizeconfig.yaml
Expand Down
4 changes: 2 additions & 2 deletions operator/config/default/kustomization.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -52,15 +52,15 @@ vars:
objref:
kind: Certificate
group: cert-manager.io
version: v1alpha2
version: v1
name: serving-cert # this name should match the one in certificate.yaml
fieldref:
fieldpath: metadata.namespace
- name: CERTIFICATE_NAME
objref:
kind: Certificate
group: cert-manager.io
version: v1alpha2
version: v1
name: serving-cert # this name should match the one in certificate.yaml
- name: SERVICE_NAMESPACE # namespace of the service
objref:
Expand Down

0 comments on commit 396586b

Please sign in to comment.