Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make GCS support optional #1018

Closed
adriangonz opened this issue Oct 31, 2019 · 0 comments · Fixed by #1019
Closed

Make GCS support optional #1018

adriangonz opened this issue Oct 31, 2019 · 0 comments · Fixed by #1019
Assignees

Comments

@adriangonz
Copy link
Contributor

Context

We currently rely on KFServing's Storage.py implementation, which adds support for Azure, GCS, S3 and local file downloading. Each of these requires its own library (e.g. google-cloud-storage, minio, etc.) However, on most cases we won't need support for all of them at the same time. Therefore, it makes sense to make some of them optional, so that seldon_core doesn't get bloated.

A good starting point for this would be making google-cloud-storage optional.

Suggested fix

In a similar way as we did for tensorflow, we could add google-cloud-storage as an optional dependency, so that it gets installed as:

$ pip install seldon_core[gcs]

On the long term, it could be good looking at libraries which offer support for the main cloud providers so that we don't need to import all of these.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant