Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistent return value for explain method in SeldonClient #1083

Closed
axsaucedo opened this issue Nov 10, 2019 · 1 comment · Fixed by #1175
Closed

Inconsistent return value for explain method in SeldonClient #1083

axsaucedo opened this issue Nov 10, 2019 · 1 comment · Fixed by #1175
Assignees
@axsaucedo
Milestone
1.0

Comments

@axsaucedo
Copy link
Contributor

Currently all methods return SeldonMessage object by default except explain method - explain REST method in SeldonClient doesn't convert the response into SeldonMessage.
@axsaucedo axsaucedo added this to the 1.0 milestone Nov 10, 2019
@axsaucedo axsaucedo self-assigned this Nov 21, 2019
@axsaucedo
Copy link
Contributor Author

Also add functionality to be able to always get JSON vs SeldonMEssage when using the Python Client.

@axsaucedo axsaucedo mentioned this issue Dec 2, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@axsaucedo axsaucedo

Labels
None yet
Projects
None yet
Milestone
1.0
Development

Successfully merging a pull request may close this issue.

Option to return proto OR dict for SeldonClient methods axsaucedo/seldon-core
1 participant
@axsaucedo