Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement] Obscure service name when deploy my yaml #1128

Closed
bestksw opened this issue Nov 22, 2019 · 1 comment
Closed

[Improvement] Obscure service name when deploy my yaml #1128

bestksw opened this issue Nov 22, 2019 · 1 comment

Comments

@bestksw
Copy link

bestksw commented Nov 22, 2019

Hi, seldon-core team.
When I deploy my yaml of kind of SeldonDeployment, Service name (especially transformer) is obscure like seldon-[sha256].
ArgoCD alwalys display service name, so It's hard to understand what service is related to in-transformer, out-transformer or something.

I really appeciate if you improve service name to have more clear.
Thx.

@bestksw bestksw changed the title [Improvement] Obscure service name when deployed [Improvement] Obscure service name when deploy my yaml Nov 22, 2019
@axsaucedo
Copy link
Contributor

@bestksw it's necessary to hash the service name if it's longer that the kubernetes allowed limit, but we've added functionality in #950 (via PR #953) which allows you to override the service name with an annotation - that should solve your issue (but you will need to make if you add names that you don't end up with duplicate service names)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants