New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong types in Seldon Core user methods #1144

Closed

axsaucedo opened this issue Nov 27, 2019 · 0 comments · Fixed by #1158

Milestone

Contributor

axsaucedo commented Nov 27, 2019

The return type here is missing Dict

seldon-core/python/seldon_core/user_model.py

Lines 33 to 36 in 8160636

    
           def predict( 
        
               self, X: np.ndarray, names: Iterable[str], meta: Dict = None 
        
           ) -> Union[np.ndarray, List, str, bytes]: 
        
               raise SeldonNotImplementedError("predict is not implemented")

axsaucedo added this to the 1.0 milestone

axsaucedo mentioned this issue

Fixing wrong types in Seldon Core user methods #1144 #1158

Merged

seldondev closed this as completed in #1158

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment