send_feedback() got an unexpected keyword argument 'routing'

[zjorgensenbits]

When sending a request to the feedback endpoint of my deployed model, I get a Microservice Error and I see the following in the container log: send_feedback() got an unexpected keyword argument 'routing'.

This is the data payload I'm sending: '{"reward": 1.0, "truth": {"data":{"names":["a","b"],"tensor":{"shape":[2,1],"values":[0,1]}}}, "response": {"data":{"names":["a","b"],"tensor":{"shape":[2,1],"values":[0,1]}}},"request": {"data":{"names":["a","b"],"tensor":{"shape":[2,1],"values":[0,1]}}}}'

[ukclivecox]

It looks like it is adding routing to the call to your microservice.

seldon-core/python/seldon_core/user_model.py

Lines 366 to 368 in f89347d

	return user_model.send_feedback(
	features, feature_names, reward, truth, routing=routing
	)

Do you have this defined in your signature for the method?

Can you explain more how you created the example? Maybe one of our docs/examples is out of date?

[zjorgensenbits]

Ahh, yes, I was using an image created from the example here: seldon-core/wrappers/s2i/python/test/model-template-app/MyModel.py
which is out of date. I fixed the send_feedback function signature and it seems to work now. I'm not getting an error, at least. Should I see any kind of response?

[ukclivecox]

Send feedback does not give a payload response at present - so a 200 http code would be all.