Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

missing python dependencies for integration tests #1504

Closed
RafalSkolasinski opened this issue Mar 4, 2020 · 2 comments · Fixed by #1535
Closed

missing python dependencies for integration tests #1504

RafalSkolasinski opened this issue Mar 4, 2020 · 2 comments · Fixed by #1535
Assignees
@RafalSkolasinski
Labels
bug
Milestone
1.1

Comments

@RafalSkolasinski
Copy link
Contributor

RafalSkolasinski commented Mar 4, 2020 •
edited
Loading

After merge of notebook tests in #1466 running them fails on local machines due to missing requirements like:

  • sklearn
  • matplotlib
  • tensorflow < 2

I believe those should be added to /testing/scripts/dev_requirements.txt.
@RafalSkolasinski RafalSkolasinski added bug triage Needs to be triaged and prioritised accordingly labels Mar 4, 2020
@RafalSkolasinski
Copy link
Contributor Author

And alibi is missing too.

@RafalSkolasinski RafalSkolasinski mentioned this issue Mar 4, 2020
Merged
@ukclivecox ukclivecox removed the triage Needs to be triaged and prioritised accordingly label Mar 6, 2020
@ukclivecox
Copy link
Contributor

ukclivecox commented Mar 6, 2020 •
edited
Loading

Core builder should reference testing/scripts/dev_requirements

@ukclivecox ukclivecox added this to the 1.1 milestone Mar 6, 2020
@RafalSkolasinski RafalSkolasinski mentioned this issue Mar 11, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RafalSkolasinski RafalSkolasinski

Labels
bug
Projects
None yet
Milestone
1.1
Development

Successfully merging a pull request may close this issue.

add notebook test deps to integration tesets requirements file
2 participants
@ukclivecox @RafalSkolasinski