We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
In the operator we are currently using zap.Logger() to instantiate a new logging object. This is inherited from the code generated by Kubebuilder.
zap.Logger()
seldon-core/operator/main.go
Line 70 in 6818fb3
However, zap.Logger() has now been deprecated for zap.New(). Kubebuilder has also updated how it generates the logging code to use the new method in kubernetes-sigs/kubebuilder#1101.
zap.New()
The text was updated successfully, but these errors were encountered:
This should be for python wrapper, executor and operator.
Sorry, something went wrong.
Moved part of the scope of this issue to #1737
Closing this one for now. The zap.Logger() method doesn't seem to be going anytime soon.
No branches or pull requests
In the operator we are currently using
zap.Logger()
to instantiate a new logging object. This is inherited from the code generated by Kubebuilder.seldon-core/operator/main.go
Line 70 in 6818fb3
However,
zap.Logger()
has now been deprecated forzap.New()
. Kubebuilder has also updated how it generates the logging code to use the new method in kubernetes-sigs/kubebuilder#1101.The text was updated successfully, but these errors were encountered: