Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use zap.New instead of zap.Logger #1657

Closed
adriangonz opened this issue Apr 3, 2020 · 3 comments
Closed

Use zap.New instead of zap.Logger #1657

adriangonz opened this issue Apr 3, 2020 · 3 comments

Comments

@adriangonz
Copy link
Contributor

adriangonz commented Apr 3, 2020

In the operator we are currently using zap.Logger() to instantiate a new logging object. This is inherited from the code generated by Kubebuilder.

ctrl.SetLogger(zap.Logger(true))

However, zap.Logger() has now been deprecated for zap.New(). Kubebuilder has also updated how it generates the logging code to use the new method in kubernetes-sigs/kubebuilder#1101.

@adriangonz adriangonz added the triage Needs to be triaged and prioritised accordingly label Apr 3, 2020
@ukclivecox ukclivecox removed the triage Needs to be triaged and prioritised accordingly label Apr 9, 2020
@ukclivecox
Copy link
Contributor

This should be for python wrapper, executor and operator.

@adriangonz adriangonz changed the title Use zap.New instead of zap.Logger Enable production flags in loggers Apr 24, 2020
@adriangonz adriangonz changed the title Enable production flags in loggers Use zap.New instead of zap.Logger Apr 24, 2020
@adriangonz
Copy link
Contributor Author

Moved part of the scope of this issue to #1737

@adriangonz
Copy link
Contributor Author

Closing this one for now. The zap.Logger() method doesn't seem to be going anytime soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants