Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

custom tags in release 1.1.0 not working #1715

Closed
JulianBarr opened this issue Apr 20, 2020 · 5 comments
Closed

custom tags in release 1.1.0 not working #1715

JulianBarr opened this issue Apr 20, 2020 · 5 comments
Assignees
Labels
bug triage Needs to be triaged and prioritised accordingly

Comments

@JulianBarr
Copy link

Hi,

I've encountered this while using 1.1.0.

I have a pipeline of a few models/transformers.

In one of the transformer, I defined a tags method as below.

def tags(self):
    return {"abc":"def"}

In subsequent transformers, in the transform_input method, I can't access the tags.

def transform_input(self, X, names, meta):
    loggers.info(meta)

It's empty.

It was working in 1.0.0 release. I was able to get the information with meta["tags"]["abc"].

@JulianBarr JulianBarr added bug triage Needs to be triaged and prioritised accordingly labels Apr 20, 2020
@RafalSkolasinski
Copy link
Contributor

RafalSkolasinski commented Apr 20, 2020

Hi @JulianBarr!

What version of s2i wrapper are you using?
For tags to work properly you need wrapper 0.19 or greater (suggest 1.1.0).

Edit: I mean to work properly with the new golang orchestrator introduced as default in 1.1

@JulianBarr
Copy link
Author

I am using 0.15. I'll try a newer version and test.

@RafalSkolasinski
Copy link
Contributor

Yes, please do. I just verified that it should be working properly.

@RafalSkolasinski
Copy link
Contributor

@JulianBarr I am closing this issue, please reopen if you find it not working properly with latest wrapper.

@JulianBarr
Copy link
Author

Ok, it works in 1.1.0.

@RafalSkolasinski RafalSkolasinski self-assigned this Apr 24, 2020
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug triage Needs to be triaged and prioritised accordingly
Projects
None yet
Development

No branches or pull requests

2 participants