Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python licenses change depending on the environment #2124

Closed
adriangonz opened this issue Jul 14, 2020 · 1 comment · Fixed by #2210
Closed

Python licenses change depending on the environment #2124

adriangonz opened this issue Jul 14, 2020 · 1 comment · Fixed by #2210
Assignees
Milestone

Comments

@adriangonz
Copy link
Contributor

Describe the bug

When generating the Python licenses using make -c python licenses, these seem to change depending on the environment. In particular, on some envs it's able to fetch the Seldon Core license and in others (e.g. JX cluster) it just returns NONE.

Since the output of the local environment and the CI server may not be the same, this causes false errors on the linting pipeline.

To reproduce

  1. Run make -C python install_dev licenses
  2. Depending on the environment, the ./python/licenses/license.txt file will list SC's license as NONE or as Apache.

Expected behaviour

The make -c python licenses command should be able to fetch SC's correct license (i.e. Apache) and not change between environments.

@adriangonz adriangonz added bug triage Needs to be triaged and prioritised accordingly labels Jul 14, 2020
@adriangonz adriangonz self-assigned this Jul 14, 2020
@adriangonz adriangonz removed the triage Needs to be triaged and prioritised accordingly label Jul 14, 2020
@adriangonz
Copy link
Contributor Author

/priority p0

@adriangonz adriangonz changed the title Python licenses seem to change depending on the environment Python licenses change depending on the environment Jul 14, 2020
@axsaucedo axsaucedo added this to the 1.2 milestone Jul 15, 2020
@ukclivecox ukclivecox modified the milestones: 1.2, 1.3 Jul 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants