Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Azure dependency optional #2168

Closed
adriangonz opened this issue Jul 20, 2020 · 0 comments · Fixed by #2170
Closed

Make Azure dependency optional #2168

adriangonz opened this issue Jul 20, 2020 · 0 comments · Fixed by #2170
Milestone
1.2

Comments

@adriangonz
Copy link
Contributor

Currently, on the Python wrapper / seldon-core package, Storage.py depends on its respective Azure, GCS and S3 dependencies. However, most of these (or only one of them) won't be used in a regular install. In fact, since we leverage the model initialiser image from the KFServing project, these won't be used at all when using modelUri in a SeldonDeployment.

It would be good to make these optional (through extra_require) as we currently already do for GCS (we could follow a similar approach).
@adriangonz adriangonz added triage Needs to be triaged and prioritised accordingly and removed triage Needs to be triaged and prioritised accordingly labels Jul 20, 2020
@adriangonz adriangonz added this to the 1.2 milestone Jul 20, 2020
@adriangonz adriangonz mentioned this issue Jul 20, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.2
Development

Successfully merging a pull request may close this issue.

Make Azure dependency optional adriangonz/seldon-core
1 participant
@adriangonz