Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change docker build context for executor to speed up build process #2186

Closed
RafalSkolasinski opened this issue Jul 23, 2020 · 2 comments · Fixed by #2335
Closed

Change docker build context for executor to speed up build process #2186

RafalSkolasinski opened this issue Jul 23, 2020 · 2 comments · Fixed by #2335
Assignees
@RafalSkolasinski
Labels
priority/p2
Milestone
1.3

Comments

@RafalSkolasinski
Copy link
Contributor

RafalSkolasinski commented Jul 23, 2020 •
edited
Loading

Adding a docker ignore files will decrease size of context send to docker daemon and therefore it should speed up image builds.

Fix docker build context on executor build
@RafalSkolasinski RafalSkolasinski added the triage Needs to be triaged and prioritised accordingly label Jul 23, 2020
@RafalSkolasinski RafalSkolasinski self-assigned this Jul 23, 2020
@RafalSkolasinski
Copy link
Contributor Author

/priority p2

@ukclivecox ukclivecox removed the triage Needs to be triaged and prioritised accordingly label Jul 23, 2020
@ukclivecox ukclivecox modified the milestones: 1.2, 1.3 Jul 23, 2020
@RafalSkolasinski
Copy link
Contributor Author

Initial scope of this was only related to the Executor as the issue is directly caused by changing context to cover symlinking the Operator.

@RafalSkolasinski RafalSkolasinski mentioned this issue Aug 27, 2020
Merged
@RafalSkolasinski RafalSkolasinski changed the title Add docker ignore mechanism to speed up docker builds Change docker build context for executor to speed up build process Aug 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RafalSkolasinski RafalSkolasinski

Labels
priority/p2
Projects
None yet
Milestone
1.3
Development

Successfully merging a pull request may close this issue.

use copy of operator instead of symlink to keep docker build context local
3 participants
@ukclivecox @RafalSkolasinski @seldondev