Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alibi Detect Drift does not use batch #2194

Closed
ukclivecox opened this issue Jul 26, 2020 · 0 comments · Fixed by #2195
Closed

Alibi Detect Drift does not use batch #2194

ukclivecox opened this issue Jul 26, 2020 · 0 comments · Fixed by #2195
Assignees
@ukclivecox
Labels
bug priority/p0
Milestone
1.2

Comments

@ukclivecox
Copy link
Contributor

Describe the bug

The drift detection predict step does not use the accumulated batch:

seldon-core/components/alibi-detect-server/adserver/cd_model.py

Line 76 in e84f710

cd_preds = self.model.predict(X)

@ukclivecox ukclivecox self-assigned this Jul 26, 2020
@ukclivecox ukclivecox added this to the 1.3 milestone Jul 26, 2020
@ukclivecox ukclivecox modified the milestones: 1.3, 1.2 Jul 27, 2020
@ukclivecox ukclivecox mentioned this issue Jul 27, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ukclivecox ukclivecox

Labels
bug priority/p0
Projects
None yet
Milestone
1.2
Development

Successfully merging a pull request may close this issue.

Fix drift predict
1 participant
@ukclivecox