Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Flag in the routing protocol to skip further processing and return #2400

Closed
parthshah86 opened this issue Sep 8, 2020 · 3 comments · Fixed by #2415
Closed

Add Flag in the routing protocol to skip further processing and return #2400

parthshah86 opened this issue Sep 8, 2020 · 3 comments · Fixed by #2415
Assignees
Milestone

Comments

@parthshah86
Copy link

We are trying to chain 3 GPU based models - model1 -> model2 -> model3 such that model2 and model3 are only run if the prediction from model1 is above a certain threshold.
To achieve this one suggestion is to extend the routing protocol to allow a new value which means to not route the call but return the current result.
https://seldondev.slack.com/archives/C8Y9A8G0Y/p1599082559154700

@parthshah86 parthshah86 added the triage Needs to be triaged and prioritised accordingly label Sep 8, 2020
@ukclivecox
Copy link
Contributor

Presently -1 means route to all children.
We could at -2 for abort and return current input?

@parthshah86
Copy link
Author

@cliveseldon that can work, to make sure I understand. The router will get the output from model1 and check the score to decide whether to return -1 or -2. And if its -1 it will forward the output of model1 to model2

@ukclivecox
Copy link
Contributor

Yes, a value X>=0 is to send to child X, no value or -1 means send output of model1 to all children.
The proposed value -2 would be to return the output of model1.
We should also extend to allow a list of N>=0 to send output of model1 to this subset of children.

@ukclivecox ukclivecox removed the triage Needs to be triaged and prioritised accordingly label Sep 10, 2020
@ukclivecox ukclivecox added this to the 1.3 milestone Sep 10, 2020
@ukclivecox ukclivecox self-assigned this Sep 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants