gRPC metrics not exposed to prometheus

[ukclivecox]

Might need to include inspired by linked project in the issue on micrometer

[tilast]

Does this issue mean that if one uses a GRPC mode for the model then metrics will not be collected by prometheus?

[ukclivecox]

Sorry missed this. Yes at present micrometer doesn't support grpc our of the box.

[tilast]

thanks! so if you say it does not support grpc out of the box, is there an existing workaround?

[pravingadakh]

@cliveseldon Is there any workaround exist for this or will we have to wait until micrometer issue is fixed?

[ukclivecox]

Well, yes I suppose a workaround is to create our own but was hoping we could continue to use micrometer. Not sure of the short term fixes that could help.

[ukclivecox]

Also, eventually we want to replace the Java engine with GoLang so then hopefully there is a grpc metrics library in GoLang for this.

[ukclivecox]

Also, we should allow metrics directly from each model. So I think this also is the best solution going forward. So out python wrappers could expose a /metrics endpoint.

[HunterEl]

Any movement on this issue?

[RafalSkolasinski]

This should be fixed in recent PR #1507 about exposing metrics directly on Python wrapper.

[RafalSkolasinski]

Please, reopen if issue is not fixed on master.

[ukclivecox]

Yes - gRPC and REST metrics will be exposed in 1.1 via the new GoLang executor:

• overview: https://docs.seldon.io/projects/seldon-core/en/latest/analytics/analytics.html
• Notebook: https://docs.seldon.io/projects/seldon-core/en/latest/examples/metrics.html

[HunterEl]

Thanks all!