Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[🚀 Feature]: Helm Chart does not support Selenium Grid Basic Auth #1890

Closed
trungprivate opened this issue Jul 13, 2023 · 5 comments
Closed

Comments

@trungprivate
Copy link
Contributor

Feature and motivation

When enabling selenium grid basic auth (by using ROUTER_USERNAME and ROUTER_PASSWORD) the autoscaling feature is not working - no nodes will get created.

Upon investigation, it was found chrome|edge|firefox.node.hpa.url is set to {{ include "seleniumGrid.graphqlURL" . }} which does not include the username/password required for basic auth.

I made a hacky change to prove this by changing chromenode.hpa.url to "http://username:password@selenium-hub:4444/graphql" which worked.

This is not ideal, and I'd like to ask if the template can be updated to support basic auth username and password in the hpa url.

Usage example

  1. Allow global variables to be specified for hub username / password
  2. If a username/password is specified, automatically pass these as environment variables to selenium hub
  3. If a username/password is specified, automatically update the hpa.url to include basic auth credentials
@github-actions
Copy link

@trungprivate, thank you for creating this issue. We will troubleshoot it as soon as we can.


Info for maintainers

Triage this issue by using labels.

If information is missing, add a helpful comment and then I-issue-template label.

If the issue is a question, add the I-question label.

If the issue is valid but there is no time to troubleshoot it, consider adding the help wanted label.

If the issue requires changes or fixes from an external project (e.g., ChromeDriver, GeckoDriver, MSEdgeDriver, W3C), add the applicable G-* label, and it will provide the correct link and auto-close the issue.

After troubleshooting the issue, please add the R-awaiting answer label.

Thank you!

@diemol
Copy link
Member

diemol commented Jul 13, 2023

Would you like to send a pull request?

@trungprivate
Copy link
Contributor Author

Sure, let me put something together and I will send through

@trungprivate
Copy link
Contributor Author

I have raised PR: #1894

Copy link

github-actions bot commented Dec 9, 2023

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Dec 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants