-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[🐛 Bug]: The Selenium Grid Scaler incorrectly scales Linux pods when Windows nodes are present in the cluster. #1925
Comments
@Doofus100500, thank you for creating this issue. We will troubleshoot it as soon as we can. Info for maintainersTriage this issue by using labels.
If information is missing, add a helpful comment and then
If the issue is a question, add the
If the issue is valid but there is no time to troubleshoot it, consider adding the
If the issue requires changes or fixes from an external project (e.g., ChromeDriver, GeckoDriver, MSEdgeDriver, W3C),
add the applicable
After troubleshooting the issue, please add the Thank you! |
I don't understand. Do you expect that Windows containers are started? |
No, the Windows nodes are located on VMs. The problem arises precisely with Linux containers when there are Windows nodes in the cluster, namely scaling fewer containers than the requested number of sessions. |
I see. I am not sure what needs to be changed to have that working. Any help is appreciated. |
This issue is looking for contributors. Please comment below or reach out to us through our IRC/Slack/Matrix channels if you are interested. |
I think trouble is not in selenium kedacore/keda#4908 (comment) |
Hi @VietND96 , I'm ultimately being ignored in the Keda project. Perhaps you have the power to fix this bug? |
@Doofus100500, I also started understanding what the scaler did in https://github.com/kedacore/keda/blob/main/pkg/scalers/selenium_grid_scaler.go and try to add a possible fix |
Yes, I noticed progress in this direction here: https://github.com/SeleniumHQ/docker-selenium/blob/trunk/charts/selenium-grid/values.yaml#L721 =) I even want to study Go lang in order to submit a Pull Request to them, but life circumstances are currently stronger than me. |
@VietND96 Hi, made a PR to keda to fix that kedacore/keda#5917 |
@Doofus100500, by fixing this, do you have any clue on the issue (in a few tickets mentioned) - when using strategy: accurate, the number of pods scales up is greater than the number of requests in the queue (e.g. 1 request - 2 or 3 pod could come up). |
@VietND96 No, I haven’t encountered such issues without Windows nodes |
What happened?
Hi, I've opened an issue in the KEDA project, but they say that the problem is in Selenium.
Command used to start Selenium Grid with Docker
Relevant log output
All the information is available in the issue at the provided link.
Operating System
k8s
Docker Selenium version (tag)
4.11.0-20230801
The text was updated successfully, but these errors were encountered: