From d4d11087786162ea1f2ba7ce1fa94267511fba47 Mon Sep 17 00:00:00 2001 From: Jason Leyba Date: Sun, 29 Oct 2017 12:55:17 -0700 Subject: [PATCH] [js] Remove more functions from firefox.Profile that are just holdovers from the legacy FirefoxDriver --- javascript/node/selenium-webdriver/CHANGES.md | 7 +++ .../selenium-webdriver/firefox/profile.js | 45 ------------------- 2 files changed, 7 insertions(+), 45 deletions(-) diff --git a/javascript/node/selenium-webdriver/CHANGES.md b/javascript/node/selenium-webdriver/CHANGES.md index c3b05b9e1bc77..7b8a959fe29f7 100644 --- a/javascript/node/selenium-webdriver/CHANGES.md +++ b/javascript/node/selenium-webdriver/CHANGES.md @@ -74,6 +74,13 @@ mode. - Added uninstallAddon(id) * Changes to `firefox.Options` - Removed setLoggingPreferences (was a no-op) +* Changes to `firefox.Profile` + - Removed no-op methods + - acceptUntrustedCerts + - assumeUntrustedCertIssuer + - setAcceptUntrustedCerts + - setAssumeUntrustedCertIssuer + - setHost * Changes to `safari.Options` - Removed setCleanSession (was a no-op) - Removed setLoggingPreferences (was a no-op) diff --git a/javascript/node/selenium-webdriver/firefox/profile.js b/javascript/node/selenium-webdriver/firefox/profile.js index 1221388957609..51ee310969c13 100644 --- a/javascript/node/selenium-webdriver/firefox/profile.js +++ b/javascript/node/selenium-webdriver/firefox/profile.js @@ -204,51 +204,6 @@ class Profile { return Object.assign({}, this.preferences_); } - /** - * Specifies which host the driver should listen for commands on. If not - * specified, the driver will default to "localhost". This option should be - * specified when "localhost" is not mapped to the loopback address - * (127.0.0.1) in `/etc/hosts`. - * - * @param {string} host the host the driver should listen for commands on - */ - setHost(host) { - this.preferences_['webdriver_firefox_allowed_hosts'] = host; - } - - /** - * @return {boolean} Whether the FirefoxDriver is configured to automatically - * accept untrusted SSL certificates. - */ - acceptUntrustedCerts() { - return !!this.preferences_['webdriver_accept_untrusted_certs']; - } - - /** - * Sets whether the FirefoxDriver should automatically accept untrusted SSL - * certificates. - * @param {boolean} value . - */ - setAcceptUntrustedCerts(value) { - this.preferences_['webdriver_accept_untrusted_certs'] = !!value; - } - - /** - * Sets whether to assume untrusted certificates come from untrusted issuers. - * @param {boolean} value . - */ - setAssumeUntrustedCertIssuer(value) { - this.preferences_['webdriver_assume_untrusted_issuer'] = !!value; - } - - /** - * @return {boolean} Whether to assume untrusted certs come from untrusted - * issuers. - */ - assumeUntrustedCertIssuer() { - return !!this.preferences_['webdriver_assume_untrusted_issuer']; - } - /** * Writes this profile to disk. * @return {!Promise} A promise for the path to the new profile