Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[🐛 Bug]: Grid closeed not wrigh, when click close button just close the remot desk page,but not disconnect the vnc. #12358

Closed
flowclouds opened this issue Jul 13, 2023 · 8 comments · Fixed by #14598
Labels
C-grid help wanted Issues looking for contributions I-defect I-stale Applied to issues that become stale, and eventually closed.

Comments

@flowclouds
Copy link

What happened?

when click close button, just close the remot desk page,but not disconnect the vnc.

How can we reproduce the issue?

1.connect remot desk window over grid session page.
2.open chrome develped tools,watch the network tab.
3.you can see new request over grid.
4.click close button.
5.you can see always request over grid vnc.

Relevant log output

blank

Operating System

linux

Selenium version

4.8.3

What are the browser(s) and version(s) where you see this issue?

chrome 111

What are the browser driver(s) and version(s) where you see this issue?

use grid docker

Are you using Selenium Grid?

4.8.3

@github-actions
Copy link

@flowclouds, thank you for creating this issue. We will troubleshoot it as soon as we can.


Info for maintainers

Triage this issue by using labels.

If information is missing, add a helpful comment and then I-issue-template label.

If the issue is a question, add the I-question label.

If the issue is valid but there is no time to troubleshoot it, consider adding the help wanted label.

If the issue requires changes or fixes from an external project (e.g., ChromeDriver, GeckoDriver, MSEdgeDriver, W3C), add the applicable G-* label, and it will provide the correct link and auto-close the issue.

After troubleshooting the issue, please add the R-awaiting answer label.

Thank you!

@diemol
Copy link
Member

diemol commented Jul 13, 2023

Does this still happen in 4.10.0?

@flowclouds
Copy link
Author

Does this still happen in 4.10.0?

ofcourse, i test it also in 4.10.0, appear the same bug.

@titusfortner
Copy link
Member

@diemol I don't understand this one, is there something we need to do for it?

@VietND96
Copy link
Member

VietND96 commented Jan 2, 2024

I guess the user wants to point to the session NoVNC live preview. He opened the session live preview, and after that he closed it. He expected the request would be finished when clicking close button, but actually it was still not finished even after the session ended.
image

@diemol
Copy link
Member

diemol commented Jan 5, 2024

It seems the WebSocket that connects to the noVNC instance is not closed when the user closes the window or when the session stops. This is something that needs to be checked and solved on the UI.

@titusfortner titusfortner added the help wanted Issues looking for contributions label Jan 5, 2024
Copy link

github-actions bot commented Jan 5, 2024

This issue is looking for contributors.

Please comment below or reach out to us through our IRC/Slack/Matrix channels if you are interested.

Copy link

This issue is stale because it has been open 280 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@github-actions github-actions bot added the I-stale Applied to issues that become stale, and eventually closed. label Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-grid help wanted Issues looking for contributions I-defect I-stale Applied to issues that become stale, and eventually closed.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants