Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calling quit() on FirefoxDriver doesn't release everything when marionette is disabled #2914

Closed
Toilal opened this issue Oct 13, 2016 · 0 comments

Comments

@Toilal
Copy link
Contributor

Toilal commented Oct 13, 2016

Meta -

OS: Windows 7

Selenium Version: 3.0.0-beta4

Browser: Firefox 46 (using FirefoxDriver with -Dwebdriver.firefox.marionette=false)

Browser Version: 46.0.1

Expected Behavior -

When calling quit() on FirefoxDriver instance, quit() method from underlying CommandExecutor instance should be invoked instance to release its resource like profile temporary directory.

Actual Behavior -

quit() is never invoked on the CommandExecutor instance.

Steps to reproduce -

Use the debugger, place a breakpoint in FirefoxDriver$LazyCommandExecutor#quit(), and invoke quit() on the FirefoxDriver instance. Breakpoint is not hit, and temporary directory from Firefox profile is not deleted until the JVM is shutdown.

Problem is that RemoveWebDriver invoke stopClient() without arguments, but this method is not overriden in FirefoxDriver. Only stopClient(Capabilities desiredCapabilities, Capabilities requiredCapabilities) is overriden.

@lukeis lukeis closed this as completed in 3d30e5e Oct 13, 2016
@lock lock bot locked and limited conversation to collaborators Aug 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants