[java] Run tests on the JUnit Platform (JUnit 5) #10752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First step in the migration of the test codebase to JUnit 5 issue SeleniumHQ#10196
…tests Second step in the migration of the test codebase to JUnit 5 issue SeleniumHQ#10196
issue #10196q
Since the existing tests are based on JUnit 4 issue SeleniumHQ#10196
Pull java_test and java_library from contrib_rules_jvm and not from the default packages issue SeleniumHQ#10196
|
Kudos, SonarCloud Quality Gate passed!
|
elgatov
pushed a commit
to elgatov/selenium
that referenced
this pull request
Jun 27, 2022
* [java] Use java_test_suite and from contrib_rule_jvm First step in the migration of the test codebase to JUnit 5 issue SeleniumHQ#10196 * [java] Manage JUnit 5 dependencies, using junit-vintage for existing tests Second step in the migration of the test codebase to JUnit 5 issue SeleniumHQ#10196 * [java] Move interface HasMagicNumbers to a separate class issue SeleniumHQ#10196 * [java] Include missing dependencies issue SeleniumHQ#10196 * [java] Include additional JUnit 5 dependencies issue #10196q * [java] Use JUnit 4 runner by default Since the existing tests are based on JUnit 4 issue SeleniumHQ#10196 * [java] Remove lint tests for contrib_rules_jvm macros Pull java_test and java_library from contrib_rules_jvm and not from the default packages issue SeleniumHQ#10196 * [java] Bump to contrib_rules_jvm version 0.3.0 * [java] Use spotbugs as linter from contrib_rules_jvm Co-authored-by: Diego Molina <diemol@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR enables
java_test_suitefromcontrib_rule_jvmto use the JUnit Platform for running test cases. It uses the JUnit 4 runner by default since most existing tests are JUnit 4-based. New test cases can be based on JUnit Jupiter. We can migrate the existing JUnit 4 tests to JUnit Jupiter as a future step.Motivation and Context
Migration of Java tests from JUnit 4 to JUnit 5 (issue #10196).
Types of changes
Checklist